[openstreetmap-website] Changeset discussion feature (#772)

[Tom Hughes]

I've done a pass through all the code now (haven't looked at tests yet) and put comments in line for your consideration.

In terms of UI issues there are a small number of things where I'd like to here what people think:

* Subscribe button location - not sure I like it where it is but don't have better ideas at the moment.
* Styling of the "login to comment" button.

There's also a major issue with the hide/unhide button - most people won't be able to see that but it looks horrible where it is. I suspect we need to make it a lot more subtle - maybe just a simple hide/unhide link at the end of the comment attribution line?

The other critical thing before we can merge is making sure everybody is happy with the API changes, which basically means:

* Adding the `include_discussion` flag to the changeset API call.
* The related changes to the XML for a changeset to include the comments.

---
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/772#issuecomment-50163749
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20140725/426b9d74/attachment.html>