[openstreetmap-website] Location of New Note marker: OK to centre it? (#1028)
danstowell
notifications at github.com
Sat Aug 8 16:24:33 UTC 2015
Discussing this with @zerebubuth while trying to work out programmatic interaction with Note creation:
The change added in commit 40b3c828e7289cc3e3566375450ee378c8229bc4 (3 Feb 2013), "Avoid making the map scroll when adding a new note". We suspect this might relate the the older "bubble" rather than "sidebar" text entry. It might be OK to simply use the map centre now.
The code is currently here:
https://github.com/openstreetmap/openstreetmap-website/blob/master/app/assets/javascripts/index/new_note.js#L111
If anyone has insight please let me know otherwise I'll check it tomorrow, and might propose simplifying it back to centreing? At present (on these laptop screens) the New Note pointer is off-centre for no obvious reason.
---
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/1028
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20150808/c2afc630/attachment.html>
More information about the rails-dev
mailing list