[openstreetmap/openstreetmap-website] Blacklist all Google imagery with one regex (#1267)
Tom Hughes
notifications at github.com
Sat Aug 13 21:51:33 UTC 2016
I can see plenty of false positives, starting with any domain containing google that isn't a google domain, for example:
```
http://test.google.compton.nu/vt?x=1&y=2&z=3
```
would match if I've read things right.
If we were happy to only match the domain before then why not stick with that but broaden the domain match? Why start trying to (badly) match the rest of the URL as well, which just means it will break every time google tweak their URLs... I mean it already matches anything with three x, y or z parameters not just those with one of each.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/1267#issuecomment-239643296
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20160813/10e079fe/attachment.html>
More information about the rails-dev
mailing list