[openstreetmap/openstreetmap-website] Use Webmock to intercept http requests in tests (#1350)

Andy Allan notifications at github.com
Tue Nov 1 11:13:44 UTC 2016


gravitystorm commented on this pull request.



> @@ -1,12 +1,12 @@
-/search?accept-language=&format=xml&q=Hoddesdon&viewbox=-0.559%2C51.766%2C0.836%2C51.217:
+/search?accept-language=&extratags=1&format=xml&q=Hoddesdon&viewbox=-0.559,51.766,0.836,51.217:

No, there's some slight differences involving the order of url parameters, and their encoding, and how toleratant webmock was being about matching regexps against their various permutations. I didn't think it was all that important (since it's just refactoring the tests, not the code) so I changed the fixtures to work rather than ratholing.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/1350
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20161101/fb423b0f/attachment.html>


More information about the rails-dev mailing list