[openstreetmap/openstreetmap-website] Diary entry comment subscriptions (#1309)

Mikel Maron notifications at github.com
Tue Oct 4 02:29:11 UTC 2016

This PR implements subscription to diary entry comments. Subscribe/unsubscribe button placed below comment box. 

A few issues remain before this is totally ready to go, could use help on the issue with tests
* https://github.com/mikelmaron/openstreetmap-website/issues/5
* https://github.com/mikelmaron/openstreetmap-website/issues/4
* https://github.com/mikelmaron/openstreetmap-website/issues/6

Also not sure about placement of button at bottom of the comments box.
You can view, comment on, or merge this pull request online at:


-- Commit Summary --

  * WIP diary comment subscriptions
  * not api endpoints, moved to button, fixed notifier message, fixed tests

-- File Changes --

    M app/controllers/diary_entry_controller.rb (43)
    M app/models/diary_entry.rb (1)
    M app/models/notifier.rb (8)
    M app/models/user.rb (1)
    M app/views/diary_entry/_diary_entry.html.erb (1)
    M app/views/diary_entry/view.html.erb (5)
    M config/locales/en.yml (24)
    M config/routes.rb (2)
    A db/migrate/20161002153425_add_join_table_between_users_and_diary_entries.rb (23)
    M test/controllers/diary_entry_controller_test.rb (97)

-- Patch Links --


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20161003/fdfc85da/attachment.html>

More information about the rails-dev mailing list