[openstreetmap/openstreetmap-website] Add a note_with_comments factory (#1317)

Tom Hughes notifications at github.com
Mon Oct 10 18:03:11 UTC 2016


Add a note_with_comments factory and migrate tests to use it, and blocks, to create notes and their associated comments in one action.

Partly I was playing with factory girl, but I also think I prefer creating the object in one go rather than creating it and then adding things to it. Maybe @gravitystorm will have some thoughts on whether we should merge this?
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/1317

-- Commit Summary --

  * Add a note_with_comments factory

-- File Changes --

    M test/controllers/browse_controller_test.rb (13)
    M test/controllers/notes_controller_test.rb (130)
    M test/controllers/site_controller_test.rb (5)
    M test/factories/notes.rb (10)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/1317.patch
https://github.com/openstreetmap/openstreetmap-website/pull/1317.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/1317
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20161010/5fb31bac/attachment.html>


More information about the rails-dev mailing list