[openstreetmap/openstreetmap-website] Replace user preferences fixture with a factory (#1337)

[Andy Allan]

Also includes a minor legibility improvement to the tests by avoiding using hardcoded user ids.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/1337

-- Commit Summary --

  * Replace hardcoded user id with a reference to the relevant user fixture
  * Replace user_preferences fixture with a factory.

-- File Changes --

    M test/controllers/trace_controller_test.rb (6)
    M test/controllers/user_preference_controller_test.rb (41)
    A test/factories/user_preferences.rb (9)
    D test/fixtures/user_preferences.yml (21)
    M test/models/user_preference_test.rb (11)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/1337.patch
https://github.com/openstreetmap/openstreetmap-website/pull/1337.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/1337
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20161026/480b2729/attachment.html>