[openstreetmap/openstreetmap-website] Use https:// for server_url (#1340)

Tom Hughes notifications at github.com
Wed Oct 26 14:33:14 UTC 2016

Well firstly that is only an example, so users are expected to customise it, and secondly I rather suspect it is used for far more than just links in password reset emails.

Most importantly of all however, it is only meant to be a hostname, and is used in places where a hostname is expected (including this exact case in fact) and the fact that adding a protocol to it currently works is mere change.

The correct fix is to add `:protocol => "https"` to https://github.com/openstreetmap/openstreetmap-website/blob/master/app/models/notifier.rb#L33 rather than trying to pass the protocol as part of `:hostname` as you are currently doing.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20161026/b82b3a68/attachment.html>

More information about the rails-dev mailing list