[openstreetmap/openstreetmap-website] Add Factorygirl as an alternative to fixtures (#1279)

Andy Allan notifications at github.com
Thu Sep 8 07:51:57 UTC 2016


Thanks for the comments. One of the problems is that the original tests are a bit pointless - they are mostly asserting that the fixtures have loaded, or that Rails itself is working (e.g. build a model from attributes, whatdoyouknow, the model has those attributes). The refactored versions are still mostly trivial, and often a bit pointless too.

I would prefer to rewrite most of these tests completely to test our "business logic" instead. But I was wary of trying to do too many things at once, since I'm always suspicious when people start rewriting tests instead of refactoring them!

I'll fix the specific points you've raised, and make a separate PR with some more thorough rewriting.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/1279#issuecomment-245520862
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20160908/f9efd31d/attachment.html>


More information about the rails-dev mailing list