[openstreetmap/openstreetmap-website] Add annotate gem and associated rake task. Annotate models. Accept new line changes in test/fixtures. (#1280)

Eric Theise notifications at github.com
Fri Sep 9 06:07:45 UTC 2016


A pull request in response to @gravitystorm's [list of ideas](https://github.com/gravitystorm/openstreetmap-website/issues/2).

This

  * adds the `annotate` gem
  * introduces a rake task at `lib/tasks/auto_annotate_models.rake` via `rails g annotate:install`
  * tweaks that task to annotate only models at the `bottom` of their `.rb`.

`annotate` polarizes developers, in my experience, and this approach is usually an acceptable intervention.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/1280

-- Commit Summary --

  * Add annotate gem and associated rake task. Annotate models. Accept new line changes in test/fixtures.

-- File Changes --

    M Gemfile (1)
    M Gemfile.lock (6)
    M app/models/access_token.rb (36)
    M app/models/acl.rb (15)
    M app/models/changeset.rb (27)
    M app/models/changeset_comment.rb (21)
    M app/models/changeset_tag.rb (17)
    M app/models/client_application.rb (31)
    M app/models/diary_comment.rb (24)
    M app/models/diary_entry.rb (28)
    M app/models/friend.rb (19)
    M app/models/language.rb (9)
    M app/models/message.rb (26)
    M app/models/node.rb (23)
    M app/models/node_tag.rb (13)
    M app/models/note.rb (20)
    M app/models/note_comment.rb (24)
    M app/models/oauth2_token.rb (36)
    M app/models/oauth2_verifier.rb (36)
    M app/models/oauth_nonce.rb (15)
    M app/models/oauth_token.rb (36)
    M app/models/old_node.rb (26)
    M app/models/old_node_tag.rb (14)
    M app/models/old_relation.rb (22)
    M app/models/old_relation_member.rb (20)
    M app/models/old_relation_tag.rb (14)
    M app/models/old_way.rb (22)
    M app/models/old_way_node.rb (18)
    M app/models/old_way_tag.rb (14)
    M app/models/redaction.rb (17)
    M app/models/relation.rb (19)
    M app/models/relation_member.rb (19)
    M app/models/relation_tag.rb (13)
    M app/models/request_token.rb (36)
    M app/models/trace.rb (27)
    M app/models/tracepoint.rb (22)
    M app/models/tracetag.rb (18)
    M app/models/user.rb (43)
    M app/models/user_block.rb (26)
    M app/models/user_preference.rb (13)
    M app/models/user_role.rb (21)
    M app/models/user_token.rb (20)
    M app/models/way.rb (19)
    M app/models/way_node.rb (18)
    M app/models/way_tag.rb (13)
    A lib/tasks/auto_annotate_models.rake (48)
    M test/fixtures/changeset_comments.yml (2)
    M test/fixtures/user_tokens.yml (1)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/1280.patch
https://github.com/openstreetmap/openstreetmap-website/pull/1280.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/1280
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20160908/7b6c730f/attachment.html>


More information about the rails-dev mailing list