[openstreetmap/openstreetmap-website] Enable the app to be built using Docker (#1290)

Paul Sturgess notifications at github.com
Fri Sep 16 07:46:36 UTC 2016


Hey guys lot's of comments. I can't address them all right at the moment but to pick one:

> There should be a COPY or ADD instruction to get the local directory to the docker instance running the rails port. I'm not sure on the semantics of copy vs add, so I don't know which is preferred.

This isn't required as the `docker-compose.yml` specifies `/app` as the `volume` which exposes the code locally on your machine to make it available in the container.

This means you can make changes locally and see them reflected when you refresh the browser.

This would obviously be different you wanted to use Docker to deploy to a production server where it would need to clone down the repo. Hopefully that makes sense!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/1290#issuecomment-247539093
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20160916/955cdbd3/attachment.html>


More information about the rails-dev mailing list