[openstreetmap/openstreetmap-website] More factory refactoring (#1529)

[Andy Allan]

This cleans up some of the fixmes within the factories themselves, as well as standard refactoring of various tests.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/1529

-- Commit Summary --

  * Use factories for all factory associations.
  * Refactor some amf_controller tests to use factories.
  * Refactor some way_controller tests to use factories.
  * Refactor deletion tests in way_controller_test to use factories.
  * Add a way_with_nodes factory, and use it in the way_controller tests.
  * Refactor more way_controller tests to use factories.
  * Refactor remaining way_controller tests to use factories.

-- File Changes --

    M test/controllers/amf_controller_test.rb (34)
    M test/controllers/way_controller_test.rb (356)
    M test/factories/changeset_tags.rb (3)
    M test/factories/old_node.rb (4)
    M test/factories/old_node_tags.rb (4)
    M test/factories/old_relation_tags.rb (4)
    M test/factories/old_way_tags.rb (4)
    M test/factories/relation.rb (4)
    M test/factories/relation_tags.rb (3)
    M test/factories/user_blocks.rb (3)
    M test/factories/way.rb (16)
    M test/factories/way_tags.rb (3)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/1529.patch
https://github.com/openstreetmap/openstreetmap-website/pull/1529.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/1529
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20170426/41098dca/attachment.html>