[openstreetmap/openstreetmap-website] Allow (un)subscribing discussions also when changeset still open (#1704)

mmd notifications at github.com
Sat Dec 16 17:07:47 UTC 2017

> Before we consider this does anybody know why the current behaviour is what it is? 

That's a really good question. Originally, my idea was to remove the "Subscribe" button on the UI. However, @pnorman's comment on https://github.com/openstreetmap/openstreetmap-website/issues/1627#issuecomment-350596170 makes sense after all. So we keep the button and remove the check for subscribe/unsubscribe in this PR instead.

That behaviour has already been introduced in the very first commit: https://github.com/openstreetmap/openstreetmap-website/pull/772 and never changed since then. It wasn't documented on the API 0.6 wiki page (until I added it last week, will remove it again once this is merged). In addition, the UI never matched the backend, see https://github.com/openstreetmap/openstreetmap-website/issues/1627#issuecomment-350635196

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20171216/9ce61cbc/attachment-0001.html>

More information about the rails-dev mailing list