[openstreetmap/openstreetmap-website] Don't display a box at all if the note event doesn't include a comment (#1432)

Hervé Saint-Amand notifications at github.com
Wed Feb 8 22:46:32 UTC 2017


Yes exactly, so if you close a note you can choose not to add a comment, and when you reopen a note you don't even have that option and there's never a comment. In both cases I think it's better to just not display a message box at all.

For other notification mails that have a message box (changeset comment, diary comment, direct message), an empty message would be odd on the part of the sender, and we can just carry that oddity across by leaving in the empty message box, I think.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/1432#issuecomment-278487450
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20170208/4e9377a6/attachment.html>


More information about the rails-dev mailing list