[openstreetmap/openstreetmap-website] Small improvement to block status display (#1445)

Tom Hughes notifications at github.com
Sun Feb 19 11:20:36 UTC 2017


tomhughes commented on this pull request.



> @@ -0,0 +1,43 @@
+# coding: utf-8
+require "test_helper"
+include ApplicationHelper

Yes, because the context there is `Object` so you wind up including the methods in `ApplicationHelper` into every single object in the system ;-)

It's not in `UserBlocksHelper` because that's a module that doesn't include it. But the things which include `UserBlocksHelper` at run time will have included it.

You should do what the browse and notes helper tests do and just include that inside the helper class.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/1445#discussion_r101914830
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20170219/36d17625/attachment-0001.html>


More information about the rails-dev mailing list