[openstreetmap/openstreetmap-website] Pass the user object, rather than the id, for sessions (#1456)

Tom Hughes notifications at github.com
Wed Feb 22 10:48:27 UTC 2017


tomhughes requested changes on this pull request.



> @@ -1578,11 +1578,11 @@ def test_query
     assert_response :success, "can't get changesets by closed-ness"
     assert_changesets [3, 5, 6, 7, 8, 9]
 
-    get :query, :closed => "true", :user => users(:normal_user).id
+    get :query, :closed => "true", :user => users(:normal_user)

This one is a query parameter and probably really should be ID and in fact I'm mystified as to how this is working because the controller code definitely wants a number for that parameter so the test framework must be converting it back to an ID as best I can tell.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/1456#pullrequestreview-23185625
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20170222/73218279/attachment.html>


More information about the rails-dev mailing list