[openstreetmap/openstreetmap-website] Make all factory-generated users 'normal' (#1459)

[Andy Allan]

The use of create(:normal_user) makes the tests needlessly harder to understand and reason about, particularly when we start using associations in the factories.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/1459

-- Commit Summary --

  * Make all factory-generated users 'normal'

-- File Changes --

    M test/controllers/amf_controller_test.rb (8)
    M test/controllers/api_controller_test.rb (2)
    M test/controllers/diary_entry_controller_test.rb (80)
    M test/controllers/notes_controller_test.rb (22)
    M test/factories/user.rb (13)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/1459.patch
https://github.com/openstreetmap/openstreetmap-website/pull/1459.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/1459
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20170222/565544bb/attachment.html>