[openstreetmap/openstreetmap-website] Diff upload does not allow forward references to placeholders (#1465)

Paul Norman notifications at github.com
Mon Feb 27 20:15:33 UTC 2017


> This can be done within any <create> block via the algorithm I gave earlier. More extensive reordering might be possible, although the explosion of different interactions is giving me a headache.
> 
> I think it would be good to have a patch for <create>-reordering, and it would help to have this in one place (i.e: the API) rather than in every editor, as long as it's not computationally onerous.
> 
> A significant downside, in my opinion, is that it makes it much harder to understand or explain what the upload call is doing. At the moment, it seems fairly easy to understand that it processes the elements in the order they appear in the upload. Reordering some kinds of changes and not others adds complexity and requires explanation, making the API more baffling. And some would say it's already plenty baffling enough.

I would favour keeping this on the client, because the client already has to reorder and combine operations to go from what the user did to an osmChange, and as you said, this adds complexity to the API. Probably significant complexity when we look at all the cases possible.

In this case the original osmChange probably came from

1. create node -1
1. add tags to node -1
1. create node -2
1. add tags to node -2
1. create relation -1
1. add node -1 to relation -1
1. add tags to relation -1
1. create relation -2
1. add relation -1 to relation -2
1. add tags to relation -2
1. create relation -3
1. add node -1 to relation -3
1. add tags to relation -3
1. add relation -3 to relation -2

When iD turned it into XML it brought step 14 before step 11.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/1465#issuecomment-282839627
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20170227/4f780ef6/attachment-0001.html>


More information about the rails-dev mailing list