[openstreetmap/openstreetmap-website] Dressed up notification mails (#1401)

[Hervé Saint-Amand]

This is ready for another wave of reviewing, I think. It uses a layout and a partial now. Please do give feedback on the particulars of the implementation.

I've added "Hi, %{user}" at the top of the changeset comment notification mail. That particular mail is probably crucial for increasing new user engagement, and it didn't have a greeting line at all. I copied the line from the message notification locale strings, in every language. Is that OK, for me to create a new localized string like this, or is this going to confuse the translation pipeline (if there is one)?

As I mentioned above, there's also a wholly new string to be localized, it goes "To unsubscribe from updates to this changeset, visit ...".

We should probably discuss the visual appearance of the messages, too. I'm thinking of writing a diary entry to bring more community feedback into this.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/1401#issuecomment-272572365
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20170113/8fbd8e60/attachment.html>