[openstreetmap/openstreetmap-website] Dressed up notification mails (#1401)

Hervé Saint-Amand notifications at github.com
Mon Jan 16 22:58:55 UTC 2017


saintamh commented on this pull request.



> @@ -0,0 +1,18 @@
+<table style="font-size: 15px; font-style: italic; margin: 15px; background-color: #eee; width: 520px">

What I was trying to convey was that this partial template is for messages (within the email message) that are written by another user. So it's for direct messages, changeset comments, diary comments and note comments. It's the box with the avatar you can see in the screenshot above. Not all notification messages have it -- the password reset email doesn't for instance. 

But words like "message" and "body" quickly get confusing I agree because we're talking about a message body (the user's message) within another message body (the email itself).

I've renamed it to `_message_body`.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/1401
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20170116/91cdfc2b/attachment.html>


More information about the rails-dev mailing list