[openstreetmap/openstreetmap-website] [WIP] Allow reporting of abusive users to moderators or admins (#1576)

Andy Allan notifications at github.com
Wed Jul 5 15:20:03 UTC 2017

Supersedes PR #1268 , see also issue #841

This PR builds on the work by @sbagroy986, @zerebubuth, @woodpeck and @grischard as we try to shepherd this GSoC project through review and into production.

I have cleaned up some aspects of this PR, purely to minimise the distractions when comparing diffs and trying to understand how it works. Please avoid nitpicking the code for now - we need to consider bigger questions first. For the avoidance of doubt, this PR not in a fit state for merging!
You can view, comment on, or merge this pull request online at:


-- Commit Summary --

  * Basic models set up
  * Controllers + a few tests + new notification added. Work pending on the notification view
  * Added authorization + issues dashboard
  * Added IssueComments + ForeignKeys + Indexes
  * basic UI for reporting diary entries,diary entry comments and user profiles
  * DB changes + Related issues added
  * Fixed tests + Added new ones
  * Fixed tests + Altered migration file + Added reporting strings + Added update method
  * Moved strings to locales + Added 'Issues' button + Fixed typo in tests
  * Issue reopens on Reports coming in after instance update
  * Added search for issues
  * Proper implementation of report strings + cleaning up
  * Added Issue Type + Issue Reassigning + Last updated_by
  * Small changes
  * Replaced check_box_tags with radio_button
  * Fixed existing tests
  * Added a few tests
  * Added a few more tests
  * Added support for reporting Changesets + Deleting issues from the CLI
  * Fixed an error + Added email notifications for moderators
  * Added report strings for Changesets and Notes + minor controller changes
  * Fixed link to DiaryComments
  * Added report icon + changes to admin UI + changes to report form + few other minor changes
  * Added sortable headers + search + reportable Notes
  * Changed report button + Added disclaimer on report page + Added search filter
  * Fixed error
  * UI changes + Redirection after creating report fixed
  * Fixed related issues positioning
  * Added helper + minor UI changes
  * Update en.yml
  * Update en-GB.yml
  * fix build on wily; fix some moderation branch language constants
  * Reordered migrations to make them the latest.
  * Made rubocop happy by formatting and minor syntax tweaks.
  * More whitespace fixes. Attempting to get tests to pass.
  * Revert changes to old migration.
  * More cleanup after tests.
  * Revert changes to Vagrantfile
  * Remove unused files
  * Whitespace fixes.
  * Revert unrelated changes from db/structure.sql

-- File Changes --

    M Gemfile (3)
    M Gemfile.lock (2)
    M app/assets/stylesheets/common.scss (51)
    M app/controllers/diary_entry_controller.rb (3)
    A app/controllers/issues_controller.rb (283)
    A app/helpers/issues_helper.rb (74)
    A app/models/issue.rb (48)
    A app/models/issue_comment.rb (6)
    M app/models/notifier.rb (11)
    A app/models/report.rb (4)
    M app/models/user.rb (6)
    M app/views/browse/changeset.html.erb (7)
    M app/views/browse/note.html.erb (5)
    M app/views/diary_entry/_diary_comment.html.erb (9)
    M app/views/diary_entry/_diary_entry.html.erb (6)
    M app/views/diary_entry/view.html.erb (6)
    A app/views/issues/_comments.html.erb (30)
    A app/views/issues/_reports.html.erb (16)
    A app/views/issues/index.html.erb (43)
    A app/views/issues/new.html.erb (43)
    A app/views/issues/show.html.erb (60)
    M app/views/layouts/_header.html.erb (3)
    A app/views/notifier/new_issue_notification.html.erb (5)
    M app/views/user/view.html.erb (8)
    M config/locales/en-GB.yml (125)
    M config/locales/en.yml (125)
    M config/routes.rb (12)
    A db/migrate/20160822153055_create_issues_and_reports.rb (41)
    A db/migrate/20160822153115_create_issue_comments.rb (18)
    A db/migrate/20160822153153_add_report_count_to_issues.rb (7)
    M db/structure.sql (257)
    A test/controllers/issues_controller_test.rb (265)
    A test/fixtures/issue_comments.yml (13)
    A test/fixtures/issues.yml (23)
    A test/fixtures/reports.yml (15)
    A test/models/issue_comment_test.rb (7)
    A test/models/issue_test.rb (7)
    A test/models/report_test.rb (7)

-- Patch Links --


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20170705/6c268ba2/attachment.html>

More information about the rails-dev mailing list