[openstreetmap/openstreetmap-website] Add tag key and value max length to capabilities API call (#1593)

Simon Poole notifications at github.com
Wed Jul 26 20:24:58 UTC 2017


Joting this down mainly for my benefit.

The root cause here seems to be a railsism that the default string length in rails is 255 characters that is mapped to character varying(255) (in PGSQL) , the down side of this is that the code is peppered with explicit references to 255 (range checking etc). From an API pov this effects at least tag key, value lengths on objects and changesets and role values for relation members. 

IM(very)HO I would refactor the code to reference a configuration value for the string length which means adding explicit limit values where necessary, this would touch a fair amount of code. One could argue that this a lot of work just so that we can actually return a max value that could in principle be set different per rails-port instance. 

@gravitystorm and @tomhughes any opinion?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/1593#issuecomment-318171714
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20170726/be47f51b/attachment.html>


More information about the rails-dev mailing list