[openstreetmap/openstreetmap-website] Use user factories for user_login integration tests (#1484)

[Andy Allan]

I've split this one out separately from the others since there's more refactoring here to consider.

The display_name logins were reworked to use downcase since the factories supply users with an already-title-cased display_name.

The tests were also renamed to align better with the purpose of the test rather than the name of the fixture used.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/1484

-- Commit Summary --

  * Use user factories for user_login integration tests.

-- File Changes --

    M test/integration/user_login_test.rb (252)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/1484.patch
https://github.com/openstreetmap/openstreetmap-website/pull/1484.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/1484
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20170310/6d31b91b/attachment.html>