[openstreetmap/openstreetmap-website] Changeset factory (#1495)

[Andy Allan]

This PR creates a changeset factory, and uses it for some of the tests.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/1495

-- Commit Summary --

  * Remove the api_fixtures call from changeset model tests, since they do not need the fixtures.
  * Create a changeset factory, and use it for model tests.
  * Use changeset factory for factory associations
  * Rework the changeset helper tests to use factories.

-- File Changes --

    M test/controllers/browse_controller_test.rb (9)
    M test/factories/changeset_comments.rb (3)
    A test/factories/changesets.rb (8)
    M test/factories/old_node.rb (3)
    M test/helpers/changeset_helper_test.rb (25)
    M test/models/changeset_comment_test.rb (5)
    M test/models/changeset_test.rb (6)
    M test/models/node_test.rb (5)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/1495.patch
https://github.com/openstreetmap/openstreetmap-website/pull/1495.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/1495
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20170322/2ace80bd/attachment.html>