[openstreetmap/openstreetmap-website] Node factories 3 (#1510)

Andy Allan notifications at github.com
Fri Mar 31 09:55:05 UTC 2017


This converts more tests to node factories. To replace the `:used_node_1` and `:node_used_by_relationship` fixtures, various new factories are introduced.

The test_delete section of node_controller_test alternated between using nodes() and current_nodes() fixtures, but I've stuck with using the Node factory consistently since it is testing other things.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/1510

-- Commit Summary --

  * Add factories for relations, relation_members, ways and way_nodes
  * Add the closed trait to changeset factories.
  * Convert more node fixtures to factories

-- File Changes --

    M test/controllers/node_controller_test.rb (101)
    M test/controllers/site_controller_test.rb (2)
    M test/factories/changesets.rb (5)
    A test/factories/relation.rb (9)
    A test/factories/relation_member.rb (9)
    A test/factories/way.rb (9)
    A test/factories/way_node.rb (8)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/1510.patch
https://github.com/openstreetmap/openstreetmap-website/pull/1510.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/1510
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20170331/7935c9a9/attachment.html>


More information about the rails-dev mailing list