[openstreetmap/openstreetmap-website] Refactor amf_controller tests (#1539)

[Andy Allan]

This PR refactors most, but not all, of the amf_controller tests to avoid using fixtures. I also spotted a couple of broken tests as I worked through them, and refactored a handful to use `result` for the amf_result array, for clarity.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/1539

-- Commit Summary --

  * Refactor some more amf_controller tests to use factories.
  * Refactor putway method tests to use factories
  * Refactor more amf_controller tests to use factories.
  * More amf_controller tests converted to use factories.

-- File Changes --

    M test/controllers/amf_controller_test.rb (335)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/1539.patch
https://github.com/openstreetmap/openstreetmap-website/pull/1539.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/1539
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20170510/e5ff1828/attachment.html>