[openstreetmap/openstreetmap-website] More factory refactoring (#1544)

[Tom Hughes]

tomhughes commented on this pull request.



> @@ -10,11 +10,16 @@ def test_db_count
   end
 
   def test_bbox
-    node = current_nodes(:used_node_1)
-    [:visible_way,
-     :invisible_way,
-     :used_way].each do |way_symbol|
-      way = current_ways(way_symbol)
+    node = create(:node)
+    visible_way = create(:way)
+    create(:way_node, :way => visible_way, :node => node)
+    invisible_way = create(:way)

That way doesn't look very invisible to me?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/1544#pullrequestreview-38687448
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20170517/4f460f90/attachment.html>