[openstreetmap/openstreetmap-website] More factories (#1554)

[Andy Allan]

More factory refactoring, mainly around the changeset controller tests.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/1554

-- Commit Summary --

  * Refactor a few tests to use changeset factories.
  * Refactor user_changeset_comments integration test to use factories.
  * Convert more changeset controller tests to use factories.
  * Refactor more changeset controller tests to use factories.
  * Convert more changeset controller tests to use factories.

-- File Changes --

    M .rubocop_todo.yml (2)
    M test/controllers/browse_controller_test.rb (6)
    M test/controllers/changeset_controller_test.rb (467)
    M test/controllers/relation_controller_test.rb (18)
    M test/controllers/way_controller_test.rb (4)
    M test/integration/user_changeset_comments_test.rb (13)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/1554.patch
https://github.com/openstreetmap/openstreetmap-website/pull/1554.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/1554
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20170531/ef203a0d/attachment.html>