[openstreetmap/openstreetmap-website] Optimised images. (#1691)
Tom Hughes
notifications at github.com
Wed Nov 29 00:42:23 UTC 2017
Changing vendored assets independently of upstream is unacceptable in any case so we certainly won't be able to take that part. Those will (if accepted upstream) filter through in due course.
That is another advantage of having the pipeline do it of course - it is acceptable for that to publish an optimised version of a third party image.
I believe image_optim was only really added to optimise the svg images so we just disabled everything else rather than having to try and validate all the other ones and make sure they didn't break anything. Enabling them will also require making sure that the necessary tools are installed by chef on the production servers but that is easy enough so long as they are packaged for ubuntu.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/1691#issuecomment-347713596
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20171129/27a30fd1/attachment.html>
More information about the rails-dev
mailing list