[openstreetmap/openstreetmap-website] allow sorting user blocks by created_at or ends_at (#1656)

Frederik Ramm notifications at github.com
Sat Oct 21 16:52:43 UTC 2017

This pull request makes the list of user blocks sortable by the end time (currently the only choice) or creation time. Sorting by creation time is useful because in practice https://www.openstreetmap.org/user_blocks is crowded out by long-time blocks, and newly created blocks first show up on page 3. To make obvious what happens, the pull request also introduces a new column for the creation time. I have another pull request that does not introduce the extra column, but it was confusing to the user to sort the table by a column that was not visible.
You can view, comment on, or merge this pull request online at:


-- Commit Summary --

  * add a column "created_at" in the list of user blocks and allow sorting by created_at or ends_at alternatively.

-- File Changes --

    A app/assets/images/down.png (0)
    M app/controllers/user_blocks_controller.rb (2)
    M app/views/user_blocks/_block.html.erb (1)
    M app/views/user_blocks/_blocks.html.erb (11)
    M config/locales/en.yml (1)

-- Patch Links --


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20171021/84e5cbd7/attachment.html>

More information about the rails-dev mailing list