[openstreetmap/openstreetmap-website] Avoid using or comparing explicit model ids (#1658)

Andy Allan notifications at github.com
Sun Oct 22 21:02:10 UTC 2017


The code is easier to read using higher-level concepts. This PR isn't comprehensive but it fixes a few obvious cases in the controllers.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/1658

-- Commit Summary --

  * Avoid using or comparing explicit model ids

-- File Changes --

    M app/controllers/changeset_controller.rb (4)
    M app/controllers/message_controller.rb (10)
    M app/controllers/user_blocks_controller.rb (8)
    M app/controllers/user_controller.rb (4)
    M app/controllers/user_roles_controller.rb (2)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/1658.patch
https://github.com/openstreetmap/openstreetmap-website/pull/1658.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/1658
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20171022/a4f38f0f/attachment.html>


More information about the rails-dev mailing list