[openstreetmap/openstreetmap-website] [WIP] Allow reporting of abusive users to moderators or admins (#1576)

[Andy Allan]

> I'm not sure I really want to try and introduce capybara as part of a big feature like this I have to say. I'd much rather we introduced that as a separate PR rather as a side effect of another project.

Oh sure - I'd introduce it as a separate PR. I just needed some feature tests right now to help work on this PR (and since I'm allergic to writing tests that interrogate forms with complex css selectors and then just do raw posts with potentially different form data, I'm avoiding controller tests for now :-) )

> That said my memory was that we were blocked on that until we were able to go to rails 5.1?

`minitest-rails-capybara` lets me write capybara-based "feature" tests in 5.0, and rails 5.1 includes built-in capybara-based "system" tests. It should just be a case of dropping the gem and changing some boiler plate because the "feature" and "system" tests have the same syntax and behaviour. There's a good chance we'll move to 5.1 before this PR is ready anyway!


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/1576#issuecomment-327568469
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20170906/64dc8789/attachment.html>