[openstreetmap/openstreetmap-website] Changeset comment list on the profile (#842)

[Paul Gillard]

I understand where you're coming from with naming this feature discussions as creating some difference between the two would be ideal. But we already:

- have a `ChangesetComment` model
- have `comment`, `hide_comment`, `unhide_comment` and `comments_feed` actions on the changeset controller
- have the term 'comment' in appropriate places on the view for the `changeset` action on the browse controller. The term 'discussion' is only used on this view as a title for the set of comments. See https://www.openstreetmap.org/changeset/52370342
- have diary comments and note comments and keeping this as changeset comments retains some consistency among these parts of the site.

To my mind the ideal solution would be to rename the comment written by the author when the changeset is created to something like remark instead. But I quite understand that isn't happening in a hurry. My point being though that if it _were_ remark I don't think anyone could argue that naming this feature changeset comments was not the best approach.

If the majority prefer changeset discussions then so be it. But I feel it's better to keep to the naming the site has already established in place despite the overlap. If it becomes too confusing for users once they actually start using it then that problem can be solved on another ticket. But it might be that it won't confuse.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/842#issuecomment-333293408
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20170930/2147515b/attachment-0001.html>