[openstreetmap/openstreetmap-website] Fix roundabout exit text (#1808)

[Jamie Guthrie]

This is basically a re-commit of #1805 , except I've removed the bit that separated out the `%{destinations}` template.

It now basically just fixes the ambiguous roundabout exit templating and refactors some of the code that builds the template name
i.e. https://www.openstreetmap.org/directions?engine=osrm_car&route=53.7338%2C-1.5258%3B53.6832%2C-1.4999#map=13/53.7086/-1.5171

(See instructions 7-16 - its not clear that every other instruction is an instruction to _leave_ the roundabout!)
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/1808

-- Commit Summary --

  * Refactored directions template building code
  * Fixed issue with some instruction template names having wrong variable order

-- File Changes --

    M app/assets/javascripts/index/directions/osrm.js (28)
    M config/locales/en.yml (91)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/1808.patch
https://github.com/openstreetmap/openstreetmap-website/pull/1808.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/1808
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20180402/61e27543/attachment-0001.html>