[openstreetmap/openstreetmap-website] Avoid hand-crafting urls (#1817)

Andy Allan notifications at github.com
Wed Apr 11 08:01:53 UTC 2018

In `app/controllers/diary_entry_controller.rb#rss` there are three links that are "hand-crafted", e.g.

@link = "#{SERVER_PROTOCOL}://#{SERVER_URL}/user/#{user.display_name}/diary"

These should instead use a helper, such as `url_for`.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20180411/20208854/attachment.html>

More information about the rails-dev mailing list