[openstreetmap/openstreetmap-website] Set default_url_options for action_mailer (#1824)

Tom Hughes notifications at github.com
Tue Apr 17 17:12:30 UTC 2018


tomhughes requested changes on this pull request.



> @@ -43,5 +43,8 @@ class Application < Rails::Application
       config.logstasher.logger_path = LOGSTASH_PATH
       config.logstasher.log_controller_parameters = true
     end
+
+    # Set the host and protocol for all action mailer urls
+    config.action_mailer.default_url_options = { :host => SERVER_URL, :protocol => SERVER_PROTOCOL }

I think this would be better in `config/initializers/action_mailer.rb` if possible. I like to restruct changes to `application.rb` to what can't go elsewhere as it makes updates easier.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/1824#pullrequestreview-112909929
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20180417/5cc8d7c2/attachment.html>


More information about the rails-dev mailing list