[openstreetmap/openstreetmap-website] Enhanced the notes search endpoint (#1955)
ENT8R
notifications at github.com
Sat Aug 25 21:12:08 UTC 2018
Follow-up of #1953 and #1954:
The `search` đ endpoint was enhanced to add the following features đ:
- get notes of a specific user đ¨ (either by the `display_name` đ or the `id` đ)
- get notes of a specific time âī¸ range (if no `to` (end time) parameter was given, it is automatically set to the current time)
- get the latest notes đ if no parameter at all was specified
I still could not figure out why the query filter does not work for the notes of a specific user đ¤ˇââī¸... (see [the code đģ](https://github.com/ENT8R/openstreetmap-website/blob/notes-search/app/controllers/notes_controller.rb#L275#L281) for more information âšī¸) Maybe someone else knows the issue just by looking at the code đ...
This PR would fix #1194 and it is at least a step towards #832...
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/1955
-- Commit Summary --
* Enhanced the notes search endpoint with a few features
-- File Changes --
M app/controllers/notes_controller.rb (46)
-- Patch Links --
https://github.com/openstreetmap/openstreetmap-website/pull/1955.patch
https://github.com/openstreetmap/openstreetmap-website/pull/1955.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/1955
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20180825/a42b47f8/attachment-0001.html>
More information about the rails-dev
mailing list