[openstreetmap/openstreetmap-website] Refactor message creation to use a create action (#1962)
Andy Allan
notifications at github.com
Wed Aug 29 06:29:05 UTC 2018
This makes it more conventional, rather than handling posts to the new action. The posting of the form was also reworked to use a hidden field for the displayname, rather than in the url, again for convention.
@Nikerabbit this PR contains some translation key changes:
* `messages.new.message_sent` => `messages.create.message_sent`
* `messages.new.limit_exceeded` => `messages.create.limit_exceeded`
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/1962
-- Commit Summary --
* Refactor message creation to use a create action
-- File Changes --
M app/controllers/messages_controller.rb (42)
M app/views/messages/new.html.erb (3)
M config/locales/en.yml (1)
M config/routes.rb (4)
M test/controllers/messages_controller_test.rb (23)
-- Patch Links --
https://github.com/openstreetmap/openstreetmap-website/pull/1962.patch
https://github.com/openstreetmap/openstreetmap-website/pull/1962.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/1962
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20180828/5a304ce0/attachment.html>
More information about the rails-dev
mailing list