[openstreetmap/openstreetmap-website] Refactor traces to be resourceful (#1964)
Andy Allan
notifications at github.com
Thu Aug 30 02:40:09 UTC 2018
This PR implements a few related changes to make traces resourceful, including renaming list->index, view->show and splitting edit into edit and update.
I put in redirects to handle the few people who might be editing trace details at the moment that this is deployed.
@Nikerabbit this PR contains translation key renaming:
* `traces.view.*` becomes `traces.show.*`
* `traces.show.edit_track` and `traces.show.delete_track` become `traces.show.edit_trace` and `traces.show.delete_trace` respectively
* `traces.list.*` becomes `traces.index.*`
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/1964
-- Commit Summary --
* Split out updating a trace into an update action
* Rename traces#view to traces#show
* Rename traces#list to traces#index
* Rename i18n keys track->trace
* Put the resourceful routing at the top of the list, for clarity
-- File Changes --
M app/controllers/api_controller.rb (2)
M app/controllers/traces_controller.rb (43)
M app/views/traces/_trace.html.erb (4)
M app/views/traces/edit.html.erb (2)
M app/views/traces/georss.rss.builder (4)
R app/views/traces/index.html.erb (4)
R app/views/traces/show.html.erb (8)
M app/views/user/view.html.erb (2)
M config/locales/en.yml (12)
M config/routes.rb (22)
M test/controllers/traces_controller_test.rb (190)
-- Patch Links --
https://github.com/openstreetmap/openstreetmap-website/pull/1964.patch
https://github.com/openstreetmap/openstreetmap-website/pull/1964.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/1964
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20180829/71113703/attachment.html>
More information about the rails-dev
mailing list