[openstreetmap/openstreetmap-website] Add total page number to notes (#2089)

[Colin Smale]

If there is an ORDER BY in the query the system already has to access
all records. And the user profile page also has a count of changesets.
Maybe this is pre-calculated and kept in the user table? Can this not be
leveraged, or is this an example of what you are "looking in due course
to get rid of"?

On 2018-12-17 15:36, Tom Hughes wrote:

> Sorry, but this isn't going to happen - in fact we probably need to get rid of the page number completely as computing the page numbers is very inefficient as it requires finding and counting the total number of matching records. 
> 
> As a general rule we don't accept anything which adds page counts to next/previous controls and we are looking in due course to get rid of those which already exist. 
> 
> --
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub [1], or mute the thread [2]. 
> _______________________________________________
> rails-dev mailing list
> rails-dev at openstreetmap.org
> https://lists.openstreetmap.org/listinfo/rails-dev
 

Links:
------
[1]
https://github.com/openstreetmap/openstreetmap-website/issues/2089#issuecomment-447867147
[2]
https://github.com/notifications/unsubscribe-auth/ABWnLWs3P-2jaXGnuC7JOQCnQBerwb2Aks5u56vqgaJpZM4ZWdSC
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20181217/6d3d343f/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: blocked.gif
Type: image/gif
Size: 118 bytes
Desc: not available
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20181217/6d3d343f/attachment.gif>