[openstreetmap/openstreetmap-website] Display coordinates on notes pages (#1773)
Aaron Lidman
notifications at github.com
Tue Feb 27 20:49:29 UTC 2018
<img width="693" alt="untitled" src="https://user-images.githubusercontent.com/58878/36753650-9ff68a00-1bbb-11e8-957d-6f20aff2382e.png">*before and after*
Fixes #1355.
Clicking note coordinates simply zooms to the area at Z18, just like node pages behave. I also cleaned up the warning, which impacted export and note creation pages. Here they are now.
<img width="351" alt="screen shot 2018-02-27 at 12 43 52 pm" src="https://user-images.githubusercontent.com/58878/36753803-2b81672a-1bbc-11e8-9393-94e28af848ec.png">
<img width="346" alt="screen shot 2018-02-27 at 12 44 13 pm" src="https://user-images.githubusercontent.com/58878/36753812-2e782fc2-1bbc-11e8-8b21-90943de00c6c.png">
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/1773
-- Commit Summary --
* Add location details to notes page, closes #1355
* Clean up warning spacing, add some color
-- File Changes --
M app/assets/stylesheets/common.scss (5)
M app/views/browse/note.html.erb (5)
M config/locales/en.yml (1)
-- Patch Links --
https://github.com/openstreetmap/openstreetmap-website/pull/1773.patch
https://github.com/openstreetmap/openstreetmap-website/pull/1773.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/1773
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20180227/5fc31bbc/attachment.html>
More information about the rails-dev
mailing list