[openstreetmap/openstreetmap-website] Refactor some messages urls (#1893)

Andy Allan notifications at github.com
Wed Jun 6 04:00:23 UTC 2018


This PR refactors the inbox and outbox paths to avoid using the display names in their urls. It does this by creating resourceful routes, but I've kept redirects for the old urls. This PR also refactors the url for showing messages (since that was easy to add) and fixes some broken translation strings that I noticed while doing so.

More refactoring of other messages methods will happen in followup PRs
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/1893

-- Commit Summary --

  * Refactor inbox and outbox paths to avoid display names in urls.
  * Refactor messages show action to be resourceful
  * Fix missing message translation strings

-- File Changes --

    M .rubocop_todo.yml (2)
    M app/controllers/messages_controller.rb (24)
    M app/views/layouts/_header.html.erb (2)
    M app/views/messages/inbox.html.erb (2)
    M app/views/messages/new.html.erb (2)
    M app/views/messages/outbox.html.erb (2)
    M app/views/messages/show.html.erb (2)
    M config/routes.rb (12)
    M test/controllers/messages_controller_test.rb (62)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/1893.patch
https://github.com/openstreetmap/openstreetmap-website/pull/1893.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/1893
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20180605/b8bc6f60/attachment.html>


More information about the rails-dev mailing list