[openstreetmap/openstreetmap-website] Remove quad_tile library and extract to gem (#1899)

Tom Hughes notifications at github.com
Wed Jun 13 23:37:08 UTC 2018


tomhughes commented on this pull request.



> @@ -1,7 +1,7 @@
 PG_CONFIG ?= pg_config
 DESTDIR ?= .
 
-QTDIR=../../lib/quad_tile
+QTDIR=./

I was already trying to figure how best to make this find the header in the quad_tile gem ;-)

I mean duplicating it like this is an option but I wonder if it's better to avoid duplication by having the gem export the path to the header?

> @@ -55,6 +55,9 @@ gem "record_tag_helper"
 gem "rinku", ">= 1.2.2", :require => "rails_rinku"
 gem "validates_email_format_of", ">= 1.5.1"
 
+#
+gem "quad_tile"

This needs to be `~> 1.0.1` as the first version doesn't actually build.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/1899#pullrequestreview-128601028
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20180613/662e0536/attachment.html>


More information about the rails-dev mailing list