[openstreetmap/openstreetmap-website] Remove if_user and similar methods (#1866)

Andy Allan notifications at github.com
Wed May 16 05:07:39 UTC 2018


Rather than hiding features based on CSS, just avoid including them in the output. Fixes #1862
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/1866

-- Commit Summary --

  * Fix test which was accidentally testing as the entry user twice
  * Remove if_user and similar methods

-- File Changes --

    M app/assets/stylesheets/common.scss (4)
    M app/helpers/application_helper.rb (38)
    M app/views/browse/changeset.html.erb (50)
    M app/views/diary_entry/_diary_comment.html.erb (6)
    M app/views/diary_entry/_diary_entry.html.erb (8)
    M app/views/diary_entry/list.html.erb (12)
    M app/views/diary_entry/view.html.erb (34)
    M app/views/layouts/_head.html.erb (1)
    M app/views/traces/list.html.erb (4)
    M app/views/traces/view.html.erb (6)
    M test/controllers/diary_entry_controller_test.rb (6)
    M test/helpers/application_helper_test.rb (102)
    M test/integration/user_changeset_comments_test.rb (4)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/1866.patch
https://github.com/openstreetmap/openstreetmap-website/pull/1866.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/1866
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20180515/ddc16499/attachment-0001.html>


More information about the rails-dev mailing list