[openstreetmap/openstreetmap-website] Add "Set home location to here" button on context menu (#1868)

Jamie Guthrie notifications at github.com
Wed May 16 23:28:22 UTC 2018


I thought it would be helpful to make setting the user's home location much easier, and save having to use the slightly clunky Settings page interface.

Now the user can just right-click anywhere on the map and select "Set home location", and their home location will be updated (provided they are logged in)

The backend process might need reworking a bit (not sure how happy you'll be using an Ajax call - However creating a new valid OSM.Router.route path seemed like a bit of an overkill!)
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/1868

-- Commit Summary --

  * Add context-menu button
  * Stop duplicate Home Location markers being added to map
  * Shortern set_home_location method and change Set Home Location Ajax call
  * Remove redundant translation

-- File Changes --

    M app/assets/javascripts/index.js (7)
    M app/assets/javascripts/index/contextmenu.js (16)
    M app/controllers/user_controller.rb (6)
    M config/locales/en.yml (1)
    M config/routes.rb (3)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/1868.patch
https://github.com/openstreetmap/openstreetmap-website/pull/1868.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/1868
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20180516/0071cb61/attachment-0001.html>


More information about the rails-dev mailing list