[openstreetmap/openstreetmap-website] Remove user_roles integration test since it is not meaningful (#2075)

Andy Allan notifications at github.com
Wed Nov 28 16:25:07 UTC 2018


This test has not been meaningful for a long while, since both `check_success` and `check_fail` contain exactly the same code.

Additionally, the test doesn't cover any integrations (beyond logging in), and so it is only covering the same ground as the controller test.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/2075

-- Commit Summary --

  * Remove user_roles integration test since it is not meaningful

-- File Changes --

    D test/integration/user_roles_test.rb (58)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/2075.patch
https://github.com/openstreetmap/openstreetmap-website/pull/2075.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2075
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20181128/fbc4a924/attachment.html>


More information about the rails-dev mailing list