[openstreetmap/openstreetmap-website] Integrate the high-performance GPX importer (#1852)

Matt Amos notifications at github.com
Wed Oct 3 15:23:25 UTC 2018


My main point was that writing Ruby/C extensions is somewhat of a specialised activity, and makes it harder to understand and modify the code. Further, even for those lucky few with the knowledge to write Ruby/C extensions, debugging across the boundary can be extremely painful.

I suspect that much of the speed improvement of C code has much more to do with not using `ActiveRecord` than anything else (perhaps this is what `activerecord-import` helps with?). Also, the observed speed improvement from being able to more widely deploy the GPX importer without fear of weird concurrency bugs (because that's sorted by `ActiveJob`) will more than make up for any speed lost due to lack of native code.

I'd recommend writing a pure-Ruby module to start with, and (re-)incorporating C only after profiling shows it's a bottleneck and it can't be solved in Ruby.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/1852#issuecomment-426678507
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20181003/27c6cc91/attachment.html>


More information about the rails-dev mailing list