[openstreetmap/openstreetmap-website] [WIP] Add links to the ToU and include them in signup (#2028)
Tom Hughes
notifications at github.com
Sun Oct 21 14:26:41 UTC 2018
tomhughes requested changes on this pull request.
In addition to the inline comments the PR descriptions claims that a link is added to the About page but that doesn't seem to be true?
> <div class="form-row">
- <label for="user_consider_pd">
- <%= check_box('user', 'consider_pd') %>
- <%= t '.consider_pd' %>
+ <label for="read_tou">
+ <%= check_box_tag 'read_tou',1,false,:onclick=>"agreebtn = document.getElementById('agree');agreebtn.disabled=!this.checked;"%>
Inline javascript is not allowed, and actually won't work on the live site as the security policy will block it in modern browsers.
You'll need to add a onclick handler to one of the js files instead...
> @@ -1989,10 +1991,14 @@ en:
terms declined: "We are sorry that you have decided to not accept the new Contributor Terms. For more information, please see <a href=\"%{url}\">this wiki page</a>."
terms declined url: https://wiki.openstreetmap.org/wiki/Contributor_Terms_Declined
terms:
- title: "Contributor terms"
- heading: "Contributor terms"
- read and accept: "Please read the agreement and press the agree button to confirm that you accept the terms of this agreement for your existing and future contributions."
- consider_pd: "In addition to the above agreement, I consider my contributions to be in the Public Domain"
+ title: "Terms"
+ heading: "Terms"
+ heading_ct: "Contributor terms"
+ read and accept: "Please read the contributor agreement and the terms of use, check the checkbox when done and then press the agree button to confirm that you accept the terms of both documents."
Changing the text of a legally significant resource like this is risky as people in other locales may continue to see the old text for a an unknown period of time - it may be better to change the name of the key to make sure people see the new text (in english) rather than the old text until the new text is translated.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2028#pullrequestreview-166787143
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20181021/cad2b8d8/attachment-0001.html>
More information about the rails-dev
mailing list