[openstreetmap/openstreetmap-website] Don't duplicate note comments in RSS feeds for new notes (#2029)

Rory McCann notifications at github.com
Mon Oct 22 07:43:49 UTC 2018


> I'm not sure who uses it and what for

I do! 🙂 I have it in my RSS reader so I can monitor the notes in an area.

> so that notes reappear when they have a new comment right?

Correct.

> But it has this weird dual thing of showing both the latest comment (that caused it to be included) and the whole thread?

Yes. When there's a "comment" on a note (including the opening of the note), there's an entry in the feed, which includes that comment, and then all the comments in/on that note. So when a note is opened, the first comment is displayed twice.

> you change doesn't really fix that because we still get the duplication the second time round - why is it a problem for a new note and not for subsequent comments?

My ruby skills are underdeveloped 😉, so I didn't try too much. This patch is an improvement, while not making things perfect.

Yes when there's the (e.g.) 5th comment on a note, that comment will appear twice (at the top and as part of the 'whole note'). IMO this isn't so bad. Including the whole note (w/ all comments in chronological order) in each feed entry is good. And including, at the top, the comment that caused this feed is good too. So I think removing the 5th comment from the 'whole note' section is bad, and removing it from the top is bad too. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2029#issuecomment-431760919
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20181022/10b3f08c/attachment.html>


More information about the rails-dev mailing list