[openstreetmap/openstreetmap-website] Added a validation to the Redaction model for the title. (#2034)

William Drumheller notifications at github.com
Wed Oct 24 03:55:44 UTC 2018


Now, a `Redaction`'s `title` must be present for it to be stored in the database.
The next question is if a test should be written to verify this in an automatic fashion. It does not appear that any of the unit tests for the `Redaction` test for the responsibility of a `Redaction` to not store invalid entries in the database. Where do we draw the line at responsibility of the rails developer / the `Redaction` model and `rails` itself?
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/2034

-- Commit Summary --

  * Added a validation to the Redaction model for the title.

-- File Changes --

    M app/models/redaction.rb (1)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/2034.patch
https://github.com/openstreetmap/openstreetmap-website/pull/2034.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2034
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20181023/0611d953/attachment-0001.html>


More information about the rails-dev mailing list